use stock pytorch defintion of python_ref_db for test_ops #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the handling of python_ref_db in XPU test utilities to use PyTorch's stock definition instead of maintaining a custom copy. The changes eliminate redundant storage and manipulation of python_ref_db while filtering it locally where needed.
Key Changes:
- Removed custom storage of
python_ref_dbin the XPU test wrapper class - Simplified
align_supported_dtypeslogic by removing complex conditional checks - Added skip list entries for newly exposed test cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/xpu/xpu_test_utils.py | Removed custom python_ref_db storage, simplified dtype alignment logic, and created local filtered version where needed |
| test/xpu/skip_list_common.py | Added skip entries for _vdot_, _dot_, _flash_attention_, and _efficient_attention_ operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Performance outliers, please check!
|
chuanqi129
approved these changes
Nov 7, 2025
CuiYifeng
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
to
disable_build
disable_e2e
disable_distributed